Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSpecify: fix for crash with wildcard types #1020

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Conversation

msridhar
Copy link
Collaborator

For now we just bail out; wildcard support will come later.

Fixes #1014

@msridhar msridhar added the jspecify Related to support for jspecify standard (see jspecify.dev) label Aug 17, 2024
@msridhar msridhar enabled auto-merge (squash) August 17, 2024 14:37
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@b37f5f9). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1020   +/-   ##
=========================================
  Coverage          ?   85.98%           
  Complexity        ?     2080           
=========================================
  Files             ?       83           
  Lines             ?     6892           
  Branches          ?     1328           
=========================================
  Hits              ?     5926           
  Misses            ?      551           
  Partials          ?      415           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@yuxincs yuxincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msridhar msridhar merged commit b20df77 into uber:master Aug 18, 2024
12 checks passed
@msridhar msridhar deleted the issue-1014 branch August 18, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jspecify Related to support for jspecify standard (see jspecify.dev)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSpecify: Another "Did not find supertype" crash, with java.lang.Exception
2 participants