more tests of passing null varargs array

uber · Sep 1, 2024 · 71301a3 · 71301a3
1 parent fee21e4
commit 71301a3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/nullaway/src/test/java/com/uber/nullaway/LegacyVarargsTests.java b/nullaway/src/test/java/com/uber/nullaway/LegacyVarargsTests.java
@@ -36,6 +36,9 @@ public void testNonNullVarargs() {
             "    Utilities.takesNonNullVarargs(o1);", // Empty var args passed
             "    // BUG: Diagnostic contains: passing @Nullable parameter 'o4' where @NonNull",
             "    Utilities.takesNonNullVarargs(o1, o4);",
+            "    Object[] x = null;",
+            "    // BUG: Diagnostic contains: passing @Nullable parameter 'x'",
+            "    Utilities.takesNonNullVarargs(o1, x);",
             "  }",
             "}")
         .doTest();

diff --git a/nullaway/src/test/java/com/uber/nullaway/VarargsTests.java b/nullaway/src/test/java/com/uber/nullaway/VarargsTests.java
@@ -32,6 +32,9 @@ public void testNonNullVarargs() {
             "    Utilities.takesNonNullVarargs(o1);", // Empty var args passed
             "    // BUG: Diagnostic contains: passing @Nullable parameter 'o4' where @NonNull",
             "    Utilities.takesNonNullVarargs(o1, o4);",
+            "    Object[] x = null;",
+            "    // BUG: Diagnostic contains: passing @Nullable parameter 'x'",
+            "    Utilities.takesNonNullVarargs(o1, x);",
             "  }",
             "}")
         .doTest();

diff --git a/nullaway/src/test/java/com/uber/nullaway/jspecify/JSpecifyVarargsTests.java b/nullaway/src/test/java/com/uber/nullaway/jspecify/JSpecifyVarargsTests.java
@@ -38,6 +38,9 @@ public void testNonNullVarargs() {
             "    Utilities.takesNonNullVarargs(o1);", // Empty var args passed
             "    // BUG: Diagnostic contains: passing @Nullable parameter 'o4' where @NonNull",
             "    Utilities.takesNonNullVarargs(o1, o4);",
+            "    Object[] x = null;",
+            "    // BUG: Diagnostic contains: passing @Nullable parameter 'x'",
+            "    Utilities.takesNonNullVarargs(o1, x);",
             "  }",
             "}")
         .doTest();
@@ -215,7 +218,7 @@ public void testSkipJetbrainsNotNullOnVarArgsFromThirdPartyJars() {
   }
 
   @Test
-  public void typeUseNullableVarargsArrayAndElements() {
+  public void typeUseNullableVarargsArray() {
     makeHelper()
         .addSourceLines(
             "Utilities.java",