Fix IncreaseLevel being reset after With #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #810 We missed implementing the increase-level logic in With and since Core was embedded, we wended up using With from the original core. To avoid this sort of issue, avoid embedding and implement all Core methods explicitly. This lets us consider the behaviour of each method explicitly.
Codecov Report
@@ Coverage Diff @@
## master #812 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 43 43
Lines 2315 2321 +6
=======================================
+ Hits 2276 2282 +6
Misses 32 32
Partials 7 7
Continue to review full report at Codecov.
|
abhinav
approved these changes
Apr 11, 2020
prashantv
force-pushed
the
fix_with_level
branch
from
ad1d358
to
3ede7e8
Compare
uvfive
pushed a commit
to bxsmart/zap
that referenced
this pull request
May 21, 2020
Fixes uber-go#810 We missed implementing the increase-level logic in With and since Core was embedded, we wended up using With from the original core. To avoid this sort of issue, avoid embedding and implement all Core methods explicitly. This lets us consider the behaviour of each method explicitly.
cgxxv
pushed a commit
to cgxxv/zap
that referenced
this pull request
Mar 25, 2022
Fixes uber-go#810 We missed implementing the increase-level logic in With and since Core was embedded, we wended up using With from the original core. To avoid this sort of issue, avoid embedding and implement all Core methods explicitly. This lets us consider the behaviour of each method explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #810
We missed implementing the increase-level logic in With
and since Core was embedded, we wended up using With from
the original core.
To avoid this sort of issue, avoid embedding and implement all
Core methods explicitly. This lets us consider the behaviour
of each method explicitly.