Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use http constants for method #597

Merged
merged 1 commit into from
May 31, 2018
Merged

use http constants for method #597

merged 1 commit into from
May 31, 2018

Conversation

etsangsplk
Copy link
Contributor

  • instead of "GET", "PUT" use constants provided by standard library

@CLAassistant
Copy link

CLAassistant commented May 30, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 30, 2018

Codecov Report

Merging #597 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #597   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files          39       39           
  Lines        2017     2017           
=======================================
  Hits         1966     1966           
  Misses         43       43           
  Partials        8        8
Impacted Files Coverage Δ
http_handler.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b73827...06e163b. Read the comment docs.

akshayjshah
akshayjshah approved these changes May 31, 2018
View reviewed changes
Copy link
Contributor

@akshayjshah akshayjshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@akshayjshah akshayjshah merged commit 88c71ae into uber-go:master May 31, 2018
jcorbin pushed a commit that referenced this pull request Jun 26, 2018
@etsangsplk
use http constants for method (#597)
dc41465
cgxxv pushed a commit to cgxxv/zap that referenced this pull request Mar 25, 2022
@etsangsplk @akshayjshah
use http constants for method (uber-go#597)
6986614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayjshah akshayjshah akshayjshah approved these changes

@billf billf billf approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@etsangsplk @CLAassistant @billf @akshayjshah