syslog writer #506
Closed
syslog writer #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows zap to write log in syslog writer
|
|
|
Thank you for the PR, @avidak! I probably won't have a chance to review it until next week. |
|
This PR is useful for a project I'm working on. Just a friendly ping. |
|
We're also waiting for this to merge. Just another friendly ping :) |
|
Thank you for the effort you put into this PR, @avidak! I've added a comment to the discussion on #96, which I won't repeat in full here. The short version is that the zap maintainers (including me) don't understand syslog well enough to support this code, so we'd prefer to keep it in a separate extension package that's owned by someone with more expertise. I'm going to close this PR - let's continue the discussion #96 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows zap to write log in syslog writer