Extend bufferpool test #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds on to the bufferpool test to write random bytes into the buffers before putting them back into the sync.Pool
|
@willhug, thanks for your PR! By analyzing the history of the files in this pull request, we identified @akshayjshah and @prashantv to be potential reviewers. |
prashantv
reviewed
Feb 27, 2017
| @@ -36,10 +37,23 @@ func TestBuffers(t *testing.T) { | |||
| buf := Get() | |||
| assert.Zero(t, buf.Len(), "Expected truncated buffer") | |||
| assert.NotZero(t, buf.Cap(), "Expected non-zero capacity") | |||
|
|
|||
| b := getRandBytes() | |||
There was a problem hiding this comment.
do we really need random data? maybe just write a constant to simplify this
const dummyData = "dummy data"
buf.WriteString(dummyData)
assert.Equal(t, buf.Len(), len(dummyData), "...")|
|
||
| func getRandBytes() []byte { | ||
| b := make([]byte, rand.Intn(5000)) | ||
| rand.Read(b) |
There was a problem hiding this comment.
technically read can return an error that is being ignored here. might be cleaner to not use this at all
akshayjshah
approved these changes
Feb 27, 2017
| "sync" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| const dummyData = "dummy data" |
There was a problem hiding this comment.
Please underscore-prefix globals.
prashantv
reviewed
Feb 27, 2017
| @@ -27,6 +27,8 @@ import ( | |||
| "github.com/stretchr/testify/assert" | |||
| ) | |||
|
|
|||
| const dummyData = "dummy data" | |||
There was a problem hiding this comment.
i'd move the const into the test since it's not used anywhere else
prashantv
approved these changes
Feb 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds on to the bufferpool test to write random bytes into
the buffers before putting them back into the sync.Pool