Add benchmarks for lion's JSON logger #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 15, 2017 11:48
From my machine: ``` testing: warning: no tests to run BenchmarkWithoutFields/go.pedge.io/lion-4 1000000 1738 ns/op 1224 B/op 10 allocs/op BenchmarkAccumulatedContext/go.pedge.io/lion-4 300000 6403 ns/op 3978 B/op 36 allocs/op BenchmarkAddingFields/go.pedge.io/lion-4 200000 9992 ns/op 5999 B/op 62 allocs/op ```
|
@akshayjshah, thanks for your PR! By analyzing the history of the files in this pull request, we identified @imkira, @peter-edge and @osamingo to be potential reviewers. |
jcorbin
approved these changes
Feb 15, 2017
bufdev
reviewed
Feb 15, 2017
| @@ -0,0 +1,31 @@ | |||
| // Copyright (c) 2016 Uber Technologies, Inc. | |||
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add benchmarks for
go.pedge.io/lion, but only benchmark the JSON logger.At some point, we may want to add protobuf benchmarks, but I'd rather not introduce dependencies on the proto compiler just for tests.
Current results (from my machine, comparable to benchmarks in README):