Add hooks to logger #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayjshah
force-pushed
the
ajs-thunks
branch
2 times, most recently
from
0b08b58 to
cfef0be
Compare
|
|
||
| func TestHookAddCaller(t *testing.T) { | ||
| buf := &bytes.Buffer{} | ||
| logger := NewJSON(All, Output(buf), ErrorOutput(ioutil.Discard), Hooks(AddCaller())) |
There was a problem hiding this comment.
here and below, suggest skipping the ErrorOutput option since the tests shouldn't produce errors. If they do, they'll go to stderr and we'll be more likely to notice them.
There was a problem hiding this comment.
Could our default hooks just implement Option so you can pass them directly without having to rewrap them?
There was a problem hiding this comment.
Great idea. Done!
Extend the logger to support a variable number of pre-log hooks. The hooks can alter the in-flight message and/or add to the logging context. For this first revision, I've included hooks to (a) annotate each log message with the logging call site, and (b) include stack traces for all log messages above a given level.
| logger := NewJSON(All, Output(buf), AddCaller()) | ||
| logger.Info("Callers.") | ||
|
|
||
| re := regexp.MustCompile(`hook_test.go:[\d]+: Callers\.`) |
There was a problem hiding this comment.
nit: can we ensure that only the base path is included, by making this look for "msg":"hook_test.go:[...]
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the logger to support a variable number of pre-log hooks. The
hooks can alter the in-flight message and/or add to the logging context.
For this first revision, I've included hooks to (a) annotate each log
message with the logging call site, and (b) include stack traces for all
log messages above a given level.