Change Logger.Log specification to "should not actually panic or exit" #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated #161 to use this, to resolve its prior note on Fatal and Panic |
4 tasks
jcorbin
force-pushed
the
log_fatal_panic
branch
from
b977ece to
0de710d
Compare
akshayjshah
approved these changes
Nov 9, 2016
| @@ -50,6 +50,11 @@ type Logger interface { | |||
|
|
|||
| // Log a message at the given level. Messages include any context that's | |||
| // accumulated on the logger, as well as any fields added at the log site. | |||
| // | |||
| // Calling Panic should panic(), calling Fatal() should terminate the | |||
There was a problem hiding this comment.
nit: "...should panic() and calling Fatal()..."
| assert.Panics(t, func() { logger.Log(PanicLevel, "foo") }, "Expected logging at Panic level to panic.") | ||
| assert.Equal(t, `{"level":"panic","msg":"foo"}`, buf.Stripped(), "Unexpected output from panic-level Log.") | ||
| }) | ||
| func TestJSONLoggerLog_panic(t *testing.T) { |
There was a problem hiding this comment.
I don't think that we're using this underscore convention in the rest of the test suite; purely for consistency, can we call these TestJSONLoggerLogPanic and ...Fatal?
There was a problem hiding this comment.
Whoops, I lied - we're using this in the bark wrapper code. Mea culpa, do as you wish.
|
lgtm, merge away. |
jcorbin
pushed a commit
that referenced
this pull request
Nov 17, 2016
jcorbin
pushed a commit
that referenced
this pull request
Nov 20, 2016
jcorbin
pushed a commit
that referenced
this pull request
Nov 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #166