Skip to content

Refactor cloned logger variable names in Sugar and WithOptions #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
htoyoda18 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −6
Open

Refactor cloned logger variable names in Sugar and WithOptions #1523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions logger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,9 @@ func NewExample(options ...Option) *Logger {
// single application to use both Loggers and SugaredLoggers, converting
// between them on the boundaries of performance-sensitive code.
func (log *Logger) Sugar() *SugaredLogger {
core := log.clone()
core.callerSkip += 2
return &SugaredLogger{core}
l := log.clone()
l.callerSkip += 2
return &SugaredLogger{l}
}

// Named adds a new path segment to the logger's name. Segments are joined by
Expand All @@ -167,11 +167,11 @@ func (log *Logger) Named(s string) *Logger {
// WithOptions clones the current Logger, applies the supplied Options, and
// returns the resulting Logger. It's safe to use concurrently.
func (log *Logger) WithOptions(opts ...Option) *Logger {
c := log.clone()
l := log.clone()
for _, opt := range opts {
opt.apply(c)
opt.apply(l)
}
return c
return l
}

// With creates a child logger and adds structured context to it. Fields added
Expand Down