Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install test dependencies before 'go vet' #129

Merged
merged 1 commit into from
Aug 9, 2016
Merged

Install test dependencies before 'go vet' #129

merged 1 commit into from
Aug 9, 2016

Conversation

billf
Copy link
Contributor

@billf billf commented Aug 9, 2016

No description provided.

@billf billf mentioned this pull request Aug 9, 2016
Merged
@prashantv
Copy link
Collaborator

Thanks for fixing this, can you also reorder the make test and make lint in the .travis.yml? That way, we'll have the lint failures fail early, and since we build the test dependencies, the go test command will run faster.

@prashantv prashantv merged commit 943c000 into uber-go:master Aug 9, 2016
@billf billf deleted the govet branch August 9, 2016 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billf @prashantv