Explicitly place table tests in named variable

This makes for slightly more readable code.
uber-go · Sep 10, 2023 · edc75e6 · edc75e6
1 parent f600804
commit edc75e6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/logger_test.go b/logger_test.go
@@ -125,7 +125,7 @@ func TestLoggerInitialFields(t *testing.T) {
 
 func TestLoggerWith(t *testing.T) {
 
-	for _, tt := range []struct {
+	tests := []struct {
 		name           string
 		initialFields  []Field
 		withMethodExpr func(*Logger, ...Field) *Logger
@@ -150,7 +150,8 @@ func TestLoggerWith(t *testing.T) {
 			[]Field{},
 			(*Logger).WithLazy,
 		},
-	} {
+	}
+	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			withLogger(t, DebugLevel, opts(Fields(tt.initialFields...)), func(logger *Logger, logs *observer.ObservedLogs) {
 				// Child loggers should have copy-on-write semantics, so two children
@@ -174,7 +175,7 @@ func TestLoggerWith(t *testing.T) {
 }
 
 func TestLoggerWithCaptures(t *testing.T) {
-	for _, tt := range []struct {
+	tests := []struct {
 		name           string
 		withMethodExpr func(*Logger, ...Field) *Logger
 		wantJSON       [2]string
@@ -211,7 +212,9 @@ func TestLoggerWithCaptures(t *testing.T) {
 				}`,
 			},
 		},
-	} {
+	}
+
+	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			enc := zapcore.NewJSONEncoder(zapcore.EncoderConfig{
 				MessageKey: "m",

diff --git a/zapcore/lazy_with_test.go b/zapcore/lazy_with_test.go
@@ -58,7 +58,7 @@ func withLazyCore(f func(zapcore.Core, *proxyCore, *observer.ObservedLogs), init
 }
 
 func TestLazyCore(t *testing.T) {
-	for _, tt := range []struct {
+	tests := []struct {
 		name          string
 		entries       []zapcore.Entry
 		initialFields []zapcore.Field
@@ -114,7 +114,8 @@ func TestLazyCore(t *testing.T) {
 				},
 			},
 		},
-	} {
+	}
+	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			withLazyCore(func(lazy zapcore.Core, proxy *proxyCore, logs *observer.ObservedLogs) {
 				checkCounts := func(withCount int64, msg string) {