Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect import path for atomic #18

Closed
leikao opened this issue Jul 26, 2019 · 2 comments · Fixed by #19
Closed

Incorrect import path for atomic #18

leikao opened this issue Jul 26, 2019 · 2 comments · Fixed by #19
Assignees
@kriskowal

Comments

@leikao
Copy link

leikao commented Jul 26, 2019

The most correct import path for atomic package should be go.uber.org/atomic, there is a mistake in the testing file:

ratelimit/ratelimit_test.go

Line 13 in c15da02

"github.com/uber-go/atomic"

@leikao
Copy link
Author

leikao commented Jul 29, 2019

ping @kriskowal @prashantv

kriskowal added a commit that referenced this issue Jul 29, 2019
@kriskowal
Fix import path for atomic test dependency
325e264 
Fixes #18

Adds a change log.
@kriskowal kriskowal mentioned this issue Jul 29, 2019
Merged
@kriskowal kriskowal self-assigned this Jul 29, 2019
kriskowal added a commit that referenced this issue Jul 29, 2019
@kriskowal
Fix import path for atomic test dependency
c5d043b 
Fixes #18

Adds a change log.
kriskowal added a commit that referenced this issue Jul 29, 2019
@kriskowal
Fix import path for atomic test dependency
6f02c18 
Fixes #18

Adds a change log.
kriskowal added a commit that referenced this issue Jul 29, 2019
@kriskowal
Fix import path for atomic test dependency (#19)
65e5b18 
Fixes #18

Adds a change log.
@kriskowal
Copy link
Contributor

Thank you @leikao. This project probably predated the canonical import. Thankfully we depended on this only for tests!

I’ve posted a tag for v0.1.0 with this fix addressed.

@leikao leikao mentioned this issue Jul 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kriskowal kriskowal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix import path for atomic test dependency uber-go/ratelimit
2 participants
@kriskowal @leikao