Avoid unnecessary map allocation in parseExcludeInterfaces #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengpeng-wang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I found that when
*excludeInterfacesat line 79 in the filemockgen/parse.gois in the form of ",,,," and " , , ", the functionparseExcludeInterfaceswill create unnecessary map allocation or maintain whitespace entries as the names of excluded interfaces [Link], which is not necessary.With this patch, the function
parseExcludeInterfacesnow returns nil instead, which more accurately represents the absence of exclusions and avoids a redundant allocation.This change is fully backward-compatible and requires no changes in downstream code. I think this patch can improve the code quality due to the better input validation and format check. Please let me know whether you need more adjustment on the patch.