Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Update partition ownership metrics #69

Merged
merged 6 commits into from
Sep 6, 2018

Conversation

georgeteo
Copy link
Collaborator

No description provided.

@georgeteo georgeteo requested a review from mmchen August 24, 2018 16:18
@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #69 into master will decrease coverage by 0.38%.
The diff coverage is 41.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   72.46%   72.08%   -0.39%     
==========================================
  Files          21       21              
  Lines        1322     1336      +14     
==========================================
+ Hits          958      963       +5     
- Misses        323      330       +7     
- Partials       41       43       +2
Impacted Files Coverage Δ
internal/consumer/topicConsumer.go 83.01% <100%> (ø) ⬆️
internal/consumer/clusterConsumer.go 61.85% <37.5%> (-5.62%) ⬇️
internal/consumer/ackMgr.go 84.44% <0%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ad657...f3d69a8. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 6, 2018

Codecov Report

Merging #69 into master will increase coverage by 0.02%.
The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   72.46%   72.48%   +0.02%     
==========================================
  Files          21       21              
  Lines        1322     1334      +12     
==========================================
+ Hits          958      967       +9     
- Misses        323      325       +2     
- Partials       41       42       +1
Impacted Files Coverage Δ
internal/consumer/topicConsumer.go 83.01% <100%> (ø) ⬆️
internal/consumer/clusterConsumer.go 67.36% <66.66%> (-0.11%) ⬇️
internal/consumer/ackMgr.go 84.44% <0%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ad657...db10504. Read the comment docs.

@@ -53,5 +53,6 @@ const (
KafkaPartitionOffsetFreshnessLag = "kafka.partition.freshness-lag"
KafkaPartitionReadOffset = "kafka.partition.read-offset"
KafkaPartitionCommitOffset = "kafka.partition.commit-offset"
KafkaPartitionOwnedCount = "kafka.partition.owned.count"
KafkaPartitionOwned = "kafka.partition.owned"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is KafkaPartitionOwned being used any more?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KafkaPartitionOwned is a gauge that determines whether a given partition is currently owned.

@georgeteo georgeteo merged commit 36e6bcb into master Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants