Remove deprecated and unused broker list. (#59)

CHANGELOG.md

@@ -8,6 +8,7 @@ v0.1.9 (unreleased)
 - Remove Offset.Initial.Reset config since it is unused.
 - Add Offset.Commit.Enabled config to enable auto offset commit.
 - Tune partition consumer logs to debug level
+- Remove Topic.BrokerList since it was unused in favor of NameResolver to resolve broker list.
 
 
 v0.1.8 (2018-06-04)

internal/consumer/clusterConsumer_test.go

@@ -68,14 +68,12 @@ func TestClusterConsumerTestSuite(t *testing.T) {
 func (s *ClusterConsumerTestSuite) SetupTest() {
 	topic := kafka.ConsumerTopic{
 		Topic: kafka.Topic{
-			Name:       "unit-test",
-			Cluster:    "production-cluster",
-			BrokerList: nil,
+			Name:    "unit-test",
+			Cluster: "production-cluster",
 		},
 		DLQ: kafka.Topic{
-			Name:       "unit-test-dlq",
-			Cluster:    "dlq-cluster",
-			BrokerList: nil,
+			Name:    "unit-test-dlq",
+			Cluster: "dlq-cluster",
 		},
 	}
 	s.topic = topic.Topic.Name

internal/consumer/multiClusterConsumer_test.go

@@ -46,14 +46,12 @@ var _ kafka.Consumer = (*MultiClusterConsumer)(nil)
 func (s *MultiClusterConsumerTestSuite) SetupTest() {
 	topic := kafka.ConsumerTopic{
 		Topic: kafka.Topic{
-			Name:       "unit-test",
-			Cluster:    "production-cluster",
-			BrokerList: nil,
+			Name:    "unit-test",
+			Cluster: "production-cluster",
 		},
 		DLQ: kafka.Topic{
-			Name:       "unit-test-dlq",
-			Cluster:    "dlq-cluster",
-			BrokerList: nil,
+			Name:    "unit-test-dlq",
+			Cluster: "dlq-cluster",
 		},
 	}
 	s.topics = []kafka.ConsumerTopic{topic}

kafka/config.go

@@ -43,10 +43,6 @@ type (
 		Name string
 		// Cluster is the logical name of the cluster to find this topic on.
 		Cluster string
-		// BrokerList for the cluster to consume this topic from
-		// If this is empty, we will get the broker list using the NameResolver
-		// TODO (gteo): remove this and rely on a NameResolver as single source for broker IP
-		BrokerList []string
 		// Delay is msg consumption delay applied on the topic.
 		Delay time.Duration
 	}

kafka/config_test.go

@@ -44,36 +44,20 @@ func (s *ConsumerConfigTestSuite) SetupTest() {
 		Topic: Topic{
 			Name:    "topic1",
 			Cluster: "cluster1",
-			BrokerList: []string{
-				"broker1",
-				"broker2",
-			},
 		},
 		DLQ: Topic{
 			Name:    "dlq_topic1",
 			Cluster: "dlq_cluster1",
-			BrokerList: []string{
-				"dlq_broker1",
-				"dlq_broker2",
-			},
 		},
 	}
 	s.topic2 = ConsumerTopic{
 		Topic: Topic{
 			Name:    "topic2",
 			Cluster: "cluster2",
-			BrokerList: []string{
-				"broker1",
-				"broker2",
-			},
 		},
 		DLQ: Topic{
 			Name:    "dlq_topic2",
 			Cluster: "dlq_cluster1",
-			BrokerList: []string{
-				"dlq_broker1",
-				"dlq_broker2",
-			},
 		},
 	}
 	s.config = ConsumerConfig{