Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wrap errors and update tests #1032

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

moisesvega
Copy link
Contributor

Use wrap error verb (%w) in some fmt.Errorf calls and update some test to avoid confusion about how to get errors and compared them.

This resolves #988

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #1032 (751ab8f) into master (5f5dc19) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1032      +/-   ##
==========================================
+ Coverage   98.04%   98.09%   +0.05%     
==========================================
  Files          39       39              
  Lines        1994     1995       +1     
==========================================
+ Hits         1955     1957       +2     
+ Misses         31       30       -1     
  Partials        8        8              
Impacted Files Coverage Δ
app.go 96.21% <ø> (ø)
annotated.go 99.17% <100.00%> (+0.16%) ⬆️
provide.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@moisesvega moisesvega merged commit 6910129 into uber-go:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Errors should be wrapped not simple passed as value
2 participants