Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
sywhang authored Oct 5, 2022
1 parent d18ea0c commit 2e4bbbb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions module_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ func TestModuleSuccess(t *testing.T) {
require.NoError(t, app.Err())

assert.Equal(t, []string{"Started", "Stopped"}, appSpy.EventTypes())
assert.Equal(t, 1, len(moduleSpy.EventTypes())
assert.Empty(t, moduleSpy.EventTypes())
})

t.Run("module uses parent module's logger to log events", func(t *testing.T) {
Expand Down Expand Up @@ -430,7 +430,7 @@ func TestModuleSuccess(t *testing.T) {
require.NoError(t, app.Err())

assert.Equal(t, []string{"Started", "Stopped"}, appSpy.EventTypes())
assert.Equal(t, []string{}, childSpy.EventTypes())
assert.Empty(t, childSpy.EventTypes())
})
}

Expand Down

0 comments on commit 2e4bbbb

Please sign in to comment.