Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gen-*): Move templates into external files #121

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

abhinav
Copy link
Collaborator

@abhinav abhinav commented Sep 6, 2022

This moves the templates used by gen-atomicint and gen-atomicwrapper
into external files embedded into the corresponding gen binary with
go:embed.

This moves the templates used by gen-atomicint and gen-atomicwrapper
into external files embedded into the corresponding gen binary with
go:embed.
@abhinav abhinav enabled auto-merge (squash) September 6, 2022 17:24
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #121 (38fd468) into master (9680036) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          231       231           
=========================================
  Hits           231       231           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@abhinav abhinav merged commit 159e329 into master Sep 6, 2022
@abhinav abhinav deleted the abg/embed branch September 6, 2022 17:26
@rabbbit
Copy link

rabbbit commented Sep 6, 2022

Out of curiosity, I understand what we did, but why did we do this?

Are there any benefits outside of general code hygiene?

@abhinav
Copy link
Collaborator Author

abhinav commented Sep 7, 2022

Just hygiene. Easier to maintain the template if it's in an external file.
I'd already made the change when I was investigating a possible fix for #120 before we decided not to.
But since the cleanup was already done, I figured it was worth sending it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants