Futurize to support Python 3 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 30, 2017 15:18
`futurize --stage2 -w opentracing_instrumentation tests`
|
Without specific domain knowledge this is difficult to review. I'm more interested in testing this diff. Is it enough to enable python 3.3 in travis, and make sure that our code works? What about parts for which we have no coverage? |
|
@oibe - low coverage areas are unfortunate, but the changes applied are more or less the same across the board. In articular, urllib2 module is fairly well tested. There are some almost untested modules but they are not affected by this change (mainly sql related). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
futurize --stage2 -w opentracing_instrumentation tests