remove config options

uber-archive · Jun 2, 2015 · f1f8486 · f1f8486
1 parent eadf486
commit f1f8486
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 13 deletions.
diff --git a/src/main/java/com/uber/jenkins/phabricator/PhabricatorNotifier.java b/src/main/java/com/uber/jenkins/phabricator/PhabricatorNotifier.java
@@ -51,7 +51,6 @@ public class PhabricatorNotifier extends Notifier {
     // Post a comment on success. Useful for lengthy builds.
     private final boolean commentOnSuccess;
     private final boolean uberallsEnabled;
-    private final String coberturaReportFile;
     private final boolean commentWithConsoleLinkOnFailure;
     private final String commentFile;
     private final String commentSize;
@@ -60,10 +59,9 @@ public class PhabricatorNotifier extends Notifier {
 
     // Fields in config.jelly must match the parameter names in the "DataBoundConstructor"
     @DataBoundConstructor
-    public PhabricatorNotifier(boolean commentOnSuccess, String coberturaReportFile, boolean uberallsEnabled,
+    public PhabricatorNotifier(boolean commentOnSuccess, boolean uberallsEnabled,
                                String commentFile, String commentSize, boolean commentWithConsoleLinkOnFailure) {
         this.commentOnSuccess = commentOnSuccess;
-        this.coberturaReportFile = coberturaReportFile;
         this.uberallsEnabled = uberallsEnabled;
         this.commentFile = commentFile;
         this.commentSize = commentSize;
@@ -328,11 +326,6 @@ public boolean isUberallsEnabled() {
         return uberallsEnabled;
     }
 
-    @SuppressWarnings("UnusedDeclaration")
-    public String getCoberturaReportFile () {
-        return coberturaReportFile;
-    }
-
     @SuppressWarnings("UnusedDeclaration")
     public boolean isCommentWithConsoleLinkOnFailure() {
         return commentWithConsoleLinkOnFailure;

diff --git a/src/main/java/com/uber/jenkins/phabricator/PhabricatorPlugin.java b/src/main/java/com/uber/jenkins/phabricator/PhabricatorPlugin.java
@@ -22,7 +22,6 @@
 
 import hudson.Plugin;
 import hudson.PluginWrapper;
-import hudson.model.Hudson;
 import jenkins.model.Jenkins;
 
 import java.io.File;
@@ -42,6 +41,6 @@ public static String getIconPath(String icon) {
         PluginWrapper wrapper = Jenkins.getInstance().getPluginManager().getPlugin(PhabricatorPlugin.class);
 
         boolean pluginIconExists = (wrapper != null) && new File(wrapper.baseResourceURL.getPath() + "/images/" + icon).exists();
-        return pluginIconExists ? "/plugin/" + wrapper.getShortName() + "/images/" + icon : Hudson.RESOURCE_PATH + "/images/16x16/" + icon;
+        return pluginIconExists ? "/plugin/" + wrapper.getShortName() + "/images/" + icon : Jenkins.RESOURCE_PATH + "/images/16x16/" + icon;
     }
 }
diff --git a/src/main/resources/com/uber/jenkins/phabricator/PhabricatorNotifier/config.jelly b/src/main/resources/com/uber/jenkins/phabricator/PhabricatorNotifier/config.jelly
@@ -13,9 +13,6 @@
            description="Post a differential comment on successful builds">
     <f:checkbox />
   </f:entry>
-  <f:entry title="Uberalls Cobertura XML" field="coberturaReportFile">
-    <f:textbox default="coverage.xml" />
-  </f:entry>
   <f:entry title="Enable Uberalls" field="uberallsEnabled"
            description="Enable code coverage reporting">
     <f:checkbox default="true" />