This repository has been archived by the owner on May 4, 2021. It is now read-only.
Handle CMD/ENTRYPOINT shell form #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rowern
force-pushed
the
better-shell-escape
branch
from
e4ee172 to
678a809
Compare
yiranwang52
reviewed
Apr 25, 2020
yiranwang52
approved these changes
Apr 28, 2020
|
Thanks, this is a pretty hard problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change the way
splitArgsworks for shell parsing, it handles some "special" characters.I also added this to the
CMDstep as it should also use the shell form if it does not use the[]form.It does work but I think this is kind of a bruteforce solution to make the
splitArgswork forENTRYPOINTandCMD. Maybe just implementing a string escaper forbase.Argswould be better... Tell me if you would prefer the escaper.@ericmeadows