This repository has been archived by the owner on May 4, 2021. It is now read-only.
Refactor copy related logic #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 22, 2020 19:56
jockech
reviewed
Apr 23, 2020
| @@ -272,7 +280,7 @@ func (c copier) copyDirContents(src, dst, origDst string, uid, gid int, preserve | |||
| } | |||
|
|
|||
| // copyDir copies the directory at src to dst. | |||
There was a problem hiding this comment.
I think it might be better to maintain the original naming. The current naming seems to copy the child of src but actually src itself is the child.
jockech
reviewed
Apr 23, 2020
| blacklist []string | ||
|
|
||
| dstDirOwner *Owner | ||
| dstFileAndChildrenOwner *Owner |
There was a problem hiding this comment.
could you clarify what dstFileAndChildrenOwner means?
jockech
reviewed
Apr 23, 2020
lib/fileio/utils.go
Outdated
| ) | ||
|
|
||
| // fileOwners returns the uid & gid that own the file. | ||
| func fileOwners(fi os.FileInfo) (uid int, gid int) { |
There was a problem hiding this comment.
may be more intuitive to call it getFileOwners.
jockech
reviewed
Apr 23, 2020
lib/fileio/copy.go
Outdated
| for _, dir := range split { | ||
| absDir := filepath.Join(prevDir, dir) | ||
| if fi, err := os.Lstat(absDir); err != nil { | ||
| for i, dir := range split { |
There was a problem hiding this comment.
for dir in range split[:len(split) -1]
jockech
reviewed
Apr 23, 2020
jockech
approved these changes
Apr 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.