Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Actions in s3 IAM Policies and using SID Field as Comment #824

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

bdu-birhanu
Copy link
Contributor

@bdu-birhanu bdu-birhanu commented Sep 15, 2024

Pull Request

Overview

This pull request provides examples on how to use "all action" and comments in s3 IAM Policies.

Proposed Changes

  • Added s3 IAM policies comments as a sub/section
  • Added "All action" in s3 IAM policies as a sub/section

Related Issues

Fixes #655

@bdu-birhanu bdu-birhanu marked this pull request as draft September 16, 2024 16:08
@bdu-birhanu bdu-birhanu marked this pull request as draft September 16, 2024 16:08
@bdu-birhanu bdu-birhanu marked this pull request as ready for review September 16, 2024 16:49
Copy link
Contributor

@wwarriner wwarriner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have you tested the policy files work as expected?

@bdu-birhanu
Copy link
Contributor Author

Yes, I have tested it.

@wwarriner wwarriner merged commit 2ae3f97 into uabrc:main Oct 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tricks and Tricks for S3 and LTS
2 participants