Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hardware table #590

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Update hardware table #590

merged 6 commits into from
Sep 15, 2023

Conversation

wwarriner
Copy link
Contributor

@wwarriner wwarriner commented Aug 18, 2023

Pull Request

Overview

Provides a manually curated table produced by scripts from here: https://github.com/wwarriner/slurm_status_tools, running on Cheaha and interacting with the manually curated hardware information table here: https://gitlab.rc.uab.edu/rc-data-science/metrics/rc-hardware.

Currently, there is not a method to link the two data sets together automatically. The manually curated hardware table is unaware of partitions, and the info coming from scontrol and sacctmgr aren't aware of the hardware details.

Any automated solution is beyond the scope of the docs, but will be proposed and followed through outside of the docs scope.

What I will do is prepare information on how I built the table and place it in the contributor guide, in a separate issue.

Proposed Changes

  • Change structure of hardware table
  • Update hardware table data
  • Modify text to fit the new table format
  • Remove superfluous text
  • Provide examples of how quotas work

Related Issues

Related to #501
Fixes #480
Fixes #353

  • 480 is resolved because all fields are reflected except Priority Tier. I don't want to advertise this one because it adds noise, and the priority and partition systems need to be re-engineered.
  • 353 is resolved because the memory reflected in the table is the actual values reported by Slurm in the "RealMem" field of scontrol.

Future work

Future #501 for general hardware page(s) improvements
Future #592 for table improvements

@wwarriner wwarriner added this to the Sprint 23-01 milestone Aug 22, 2023
Copy link
Contributor

@Premas Premas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

@Premas Premas merged commit 9323bbc into uabrc:main Sep 15, 2023
@wwarriner wwarriner deleted the fix-hardware-table branch September 26, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve hardware page Hardware tables do not have reserved nor available memory listed
3 participants