Fix scheduled release action for builtins#260
Merged
masklinn merged 3 commits intoua-parser:masterfrom Feb 15, 2025
Merged
Conversation
Apparently the way submodules repos are configured leads to the branches not being mirrored locally (?) As such, the release job's fallback of checking out `'master'` fails whether triggered[^1] or scheduled[^2]. [^1]: https://github.com/ua-parser/uap-python/actions/runs/13090871627 [^2]: https://github.com/ua-parser/uap-python/actions/runs/13092233962
Since the environment is required via `workflow_dispatch`, the only fallback is scheduled release in which case we're publishing to pypy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow didn't work because it falls back to the ref
"master"which the checkout does not understand. Furthermore because there is no explicit environment in the scheduled case the job description says it's deploying to "dummy" which is not true and also not really convenient.It would be better if we could set inputs for other trigger events than
workflow_dispatch(and I assumeworkflow_callor whatever it's called), but apparently not.