-
Notifications
You must be signed in to change notification settings - Fork 31
fix: Use only 4.1.x version of superstatic not 4.x #493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
@vertein what version of npm are you running?
Some of the integrity
hashes in package-lock.json
are dropping from sha512
to sha1
which seems somewhat unexpected.
🍎 OS X build is failing with
https://travis-ci.org/UW-Madison-DoIT/uw-frame/jobs/264812988#L123-L137 Restarting build to see if that resolves error 🏗️ edit after restart, build passes ✅ |
5d0f185
to
aa6aab8
Compare
Running npm version 5.3.0 but was running node version 8 something. An issue search showed that others ran into the same thing. I downgraded my node to a stable version and it looks like it corrected the problem. I pushed a new file that looks better. Thanks for restarting the job, it was successful. I pushed up the new package-lock file, so I won't merge until the checks run again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @vertein!
Superstatic version 4.2 introduced a dependency on shrink-ray, which introduced a dependency on node-zopfli, which introduces the need for a c compiler when building. We're using the mvn deploy command to push out new releases. This calls a mvn exec command 'npm install'. npm install still 'succeeded' before, but exited with a code 1 (definitions of succeed vary), causing the mvn deploy command to fail.
Contributor License Agreement adherence: