Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

fix: Use only 4.1.x version of superstatic not 4.x #493

Merged
merged 1 commit into from
Aug 15, 2017

Conversation

vertein
Copy link
Contributor

@vertein vertein commented Aug 15, 2017

Superstatic version 4.2 introduced a dependency on shrink-ray, which introduced a dependency on node-zopfli, which introduces the need for a c compiler when building. We're using the mvn deploy command to push out new releases. This calls a mvn exec command 'npm install'. npm install still 'succeeded' before, but exited with a code 1 (definitions of succeed vary), causing the mvn deploy command to fail.


Contributor License Agreement adherence:

Copy link
Contributor

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@vertein what version of npm are you running?
Some of the integrity hashes in package-lock.json are dropping from sha512 to sha1 which seems somewhat unexpected.

@ChristianMurphy
Copy link
Contributor

ChristianMurphy commented Aug 15, 2017

🍎 OS X build is failing with

/Users/travis/build/UW-Madison-DoIT/uw-frame/node_modules/less/lib/less/functions/function-caller.js:1
(function (exports, require, module, __filename, __dirname) { �
                                                              ^
SyntaxError: Invalid or unexpected token
    at createScript (vm.js:74:10)
    at Object.runInThisContext (vm.js:116:10)
    at Module._compile (module.js:537:28)
    at Object.Module._extensions..js (module.js:584:10)
    at Module.load (module.js:507:32)
    at tryModuleLoad (module.js:470:12)
    at Function.Module._load (module.js:462:3)
    at Module.require (module.js:517:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/travis/build/UW-Madison-DoIT/uw-frame/node_modules/less/lib/less/tree/call.js:2:22)

https://travis-ci.org/UW-Madison-DoIT/uw-frame/jobs/264812988#L123-L137

Restarting build to see if that resolves error 🏗️

edit after restart, build passes ✅
it appears error was a fluke.

@vertein
Copy link
Contributor Author

vertein commented Aug 15, 2017

Running npm version 5.3.0 but was running node version 8 something. An issue search showed that others ran into the same thing. I downgraded my node to a stable version and it looks like it corrected the problem. I pushed a new file that looks better.

Thanks for restarting the job, it was successful. I pushed up the new package-lock file, so I won't merge until the checks run again.

Copy link
Contributor

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vertein!

@vertein vertein merged commit 4f0dbb5 into uPortal-Attic:master Aug 15, 2017
@vertein vertein deleted the badSuperStatic branch August 15, 2017 17:51
@davidmsibley davidmsibley modified the milestone: 5.0.0 Aug 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants