Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

style(less): Add Stylelint #485

Merged
merged 4 commits into from
Aug 8, 2017
Merged

style(less): Add Stylelint #485

merged 4 commits into from
Aug 8, 2017

Conversation

ChristianMurphy
Copy link
Contributor

@ChristianMurphy ChristianMurphy commented Aug 6, 2017 •
edited
Loading

Applies style checking to less files to ensure they are consistent and readable.

Part of #379

Contributor License Agreement adherence:

@ChristianMurphy
build(npm): add stylelint
d489ab8 
add stylelint to manage less style validation.
add stylelint config standard to provide rule set.
add 'lint-css' script to run stylelint.

issue #379
@ChristianMurphy
ci(travis): Add stylelint checks to travis ci
0b21b47 
automatically run less style checks as part of travis ci build.

issue #379
@ChristianMurphy
ci(appveyor): add eslint and stylelint to appveyor
c81bcbe 
automatically check JavaScript and Less code style as part of Windows CI
process.

issue #379
@ChristianMurphy
style(less): Apply stylelint standard styles to less
14e597e 
Check through less files ensuring code matches stylelint standard.

issue #379
davidmsibley
davidmsibley approved these changes Aug 8, 2017
View reviewed changes
Copy link
Contributor

@davidmsibley davidmsibley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of short color codes, but can't win 'em all.

@ChristianMurphy
Copy link
Contributor Author

The rules are configurable, if it goes against the direction uw-frame wants to go 🙅‍♂️ , that can be changed. 🔙
But for this pass I stuck with the defaults. ✅

@davidmsibley
Copy link
Contributor

Defaults are good

@ChristianMurphy ChristianMurphy merged commit f0603e3 into uPortal-Attic:master Aug 8, 2017
@ChristianMurphy ChristianMurphy deleted the stylelint branch August 8, 2017 20:13
@davidmsibley davidmsibley modified the milestone: 5.0.0 Aug 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidmsibley davidmsibley davidmsibley approved these changes

Assignees
No one assigned
Labels
patch version bump
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristianMurphy @davidmsibley