This repository has been archived by the owner on May 4, 2022. It is now read-only.
Compact widget directive #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
approved these changes
Apr 28, 2017
| <!-- ng-click="layoutCtrl.removePortlet(widget.nodeId, widget.title)" --> | ||
| <!-- ng-hide="GuestMode || cantRemove"> --> | ||
| <!-- <md-icon>close</md-icon> --> | ||
| <!-- </md-button> --> |
There was a problem hiding this comment.
Is the commented out code needed?
There was a problem hiding this comment.
Great catch! Removed it to prove that I didn't need it, but didn't actually remove it
thevoiceofzeke
approved these changes
Apr 28, 2017
apetro
approved these changes
Apr 28, 2017
| @@ -0,0 +1,17 @@ | |||
| <md-card class="list-content" id="widget-id-{{::widget.nodeId}}"> | |||
| <md-button class="widget-action widget-info md-icon-button" aria-label="see a brief description of this app"> | |||
There was a problem hiding this comment.
aria-label is good. As I understand it it would be better if the label included the name of the app that one would see a brief description of, so that screen reader user has more context in consuming that label.
There was a problem hiding this comment.
Good catch. I just copied and pasted a partial from before. It's always good to be better. Updated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves more widget code from uPortal-home to the uPortal-App-Framework, so everyone can enjoy a good compact mode widget.
Fixes a bug in uPortal-home where compact mode wasn't rendering because of switching to the new layout call in portal
Contributor License Agreement adherence: