Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the lists activate by default in browser languages that are minority languages in the lists' countries #501

Closed
DandelionSprout opened this issue Apr 1, 2019 · 0 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@DandelionSprout
Copy link

DandelionSprout commented Apr 1, 2019

Inspired by gorhill/uBlock#3754, I began to look into https://www.mozilla.org/en-GB/firefox/all/ as well as Vivaldi's language settings, and saw that there's a fair few languages that simultaneously 1) have translations of Firefox, Vivaldi, or both, 2) are too small to ever get their own lists, and 3) are either minority languages in a larger country, are pretty closely related to a larger language, or (in the case of RUS) are often sidelined by Russian in their own countries.

Thus I am proposing that the following language codes be added to the assets.json entries for the corresponding large-language lists (e.g. Kazakh to RU AdList and AdGuard Russian), so that they're activated by default for those who use web browsers in such languages.

Regional list set Minor languages that they could be activated for
BGR Macedonian (mk)
SPA Catalan (ca), Galician (gl), Basque (eu), Aragonese (an)⁰, Asturian (ast)⁰
POR Galician (gl)
DEU Swiss German (gsw [and/or] de_CH)
RUS Kazakh (kk), Uzbek (uz)
NLD Frisian (fy)⁰, Afrikaans (af)⁰
FRA Occitan (oc)⁰, Breton (br)⁰
ITA Ligurian (lij)⁰

means that I couldn't confirm that a list had any entries for such languages (The absence of it means that I found at least one entry for that language in those lists).

Additionally, I've submitted 12 Macedonian entries through E-mail to the maintainer of Bulgarian List. If he accepts my offer, thus meaning that his list would be properly dealing with Macedonian websites, then there'd even be grounds to change the menu entry for his list to BGR, MKD: Bulgarian Adblock List.

@DandelionSprout DandelionSprout changed the title Make the lists also cover browser languages that are minority languages in the lists' countries Make the lists activate by default in browser languages that are minority languages in the lists' countries Apr 1, 2019
@uBlock-user uBlock-user added the enhancement New feature or request label Apr 1, 2019
gorhill added a commit to gorhill/uBlock that referenced this issue Apr 14, 2019
Related issue:
- uBlockOrigin/uBlock-issues#501

Also, the handling of 3-letter language codes has been fixed.
gorhill added a commit to gorhill/uBlock that referenced this issue Apr 14, 2019
@uBlock-user uBlock-user added the fixed issue has been addressed label Apr 15, 2019
JustOff pushed a commit to JustOff/uBlock that referenced this issue Jan 2, 2020
Related issue:
- uBlockOrigin/uBlock-issues#501

Also, the handling of 3-letter language codes has been fixed.
JustOff pushed a commit to JustOff/uBlock that referenced this issue Jan 2, 2020
gorhill added a commit to gorhill/uBlock that referenced this issue Jan 2, 2020
* adress DandelionSprout/adfilt#7 (comment) (#3754)

* Add more languages for list selection at install/reset time

Related issue:
- uBlockOrigin/uBlock-issues#501

Also, the handling of 3-letter language codes has been fixed.

* Forgot to add `lij` re. uBlockOrigin/uBlock-issues#501

* Cater to legacy javascript engines

* Fix uBlockOrigin/uBlock-issues#531

* Fix NanoMeow/QuickReports#1091

* Removed seemingly abandoned "DNK: Schacks" list

Related discussion:
- DandelionSprout/adfilt#7 (comment)

* Remove "RUS: AdGuard Russian" from stock filter list

As per feedback from maintainers, AdGuard Russian
and RU AdList are incompatible and web site breakage
can occur when both are used together.

Related issue:
- uBlockOrigin/uBlock-issues#749

* Rename "Fanboy Cookie" to "EasyList Cookie" + update list link

Related issue:
- uBlockOrigin/uBlock-issues#804

Co-authored-by: okiehsch <okiehsch@users.noreply.github.com>
Co-authored-by: Raymond Hill <gorhill@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

2 participants