Properly report `:spath` operator of procedural cosmetic filters in logger

[krystian3w]

Prerequisites

• I verified that this is not a filter issue
  • Filter issues MUST be reported at filter issue tracker
• This is not a support issue or a question
  • Support issues and questions are handled at /r/uBlockOrigin
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • Your issue may already be reported.
• I tried to reproduce the issue when...
  • uBlock Origin is the only extension
  • uBlock Origin with default lists/settings
  • using a new, unmodified browser profile
• I am running the latest version of uBlock Origin
• I checked the documentation to understand that the issue I report is not a normal behavior

Description

Block someting with xpath and use comma after xpath:

github.com###issue-418448972:xpath(..), blablacar

Try find logger and you found:

Logger output

+4	###issue-418448972:xpath(..):spath(, blablacar)		github.com		dom	https://github.com/uBlockOrigin/uBlock-issues/issues/453

A specific URL where the issue occurs

#453

Steps to Reproduce

1. open this issue Properly report :spath operator of procedural cosmetic filters in logger #453
2. create filter by element picker ##.js-comment-body:xpath(..), blablacar
3. refresh page and possible in ubo logger you found ##.js-comment-body:xpath(..):spath(, blablacar)

Expected behavior:

mark filter as invalid?

or add works exception + marks spath as valid operator:

#@##issue-418448972:xpath(..):spath(, li)

Actual behavior:

other selector moved to :spath(...) to not discard filter? and expception without remove spath does not work.

Your environment

• uBlock Origin version: Windows 7
• Browser Name and version: Firefox 65
• Operating System and version: uBO 1.18.5rc3

:spath is to support chaining back from procedural to native CSS selectors

In github.com###issue-418448972:xpath(..) div.avatar-parent-child, div.avatar-parent-child should be in "spath".

• I was sure it's only internal and should not be visible in logger (?). Should be added to wiki "Procedural cosmetic filters"?
• comma is confusing filter parser

[krystian3w]

Also strange is exception with :spath does not working?

[mapx-]

@gwarser it's about https://github.com/orgs/uBlockOrigin/teams/ublock-issues-volunteers/discussions/59 , right ?

[mapx-]

it wasn't implemented support of comma-separated procedurals

it's about...

Yep, this is it.

gorhill on Dec 30, 2018 •

I didn't implement support of comma-separated procedurals, an issue will have to be opened about this, and given that the workaround is to simply declare each on its own line, it's unlikely to be something I will work on this for now. That is unless such filters become a common occurrence in other lists (or if I figure a trivial fix to this).

But I still want to know if :spath should be displayed in the logger. If yes, it should be added to the wiki to tell people what it is.

Also strange is exception with :spath does not working?

? You mean, something like this: #@#.js-comment-body:xpath(..):spath(.real-class) ?

[krystian3w]

Yes, I need remove ":spath( " (with space), and ")" form filter generated by uBO logger/ uBO dom inspector, otherwise it does not work as exception.

---

github.com##.js-comment-body:xpath(../../../../../../../..) div.avatar-parent-child

no recover avatars:
github.com#@#.js-comment-body:xpath(../../../../../../../..):spath( div.avatar-parent-child)

[gorhill]

Don't use :spath, it's for internal use only.

[krystian3w]

I am no use, Logger "recommed" exception with spath.