uBO does not unhide nodes no longer matching procedural cosmetic filters

[krystian3w]

Prerequisites

• I checked the documentation to understand that the issue I report is not a normal behavior
• I verified that this is not a filter issue
  • Filter issues MUST be reported at filter issue tracker
• This is not a support issue or a question
  • Support issues and questions are handled at /r/uBlockOrigin
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • Your issue may already be reported.
• I tried to reproduce the issue when...
  • uBlock Origin is the only extension
  • uBlock Origin with default lists/settings
  • using a new, unmodified browser profile
• I am running the latest version of uBlock Origin

Description

e.g.

##.nytc---modal-window---isShown:if-not(.nytc---largepicturemodal---contentBody > .nytc---x---x.nytc---largepicturemodal---xBtn[role="button"])

filter cut to much in uBO on cooking.nytimes.com.

A specific URL where the issue occurs

https://cooking.nytimes.com/recipes/1018016-pot-roast
https://cooking.nytimes.com/recipes/1650-italian-pot-roast-stracotto

uBlockOrigin/uAssets#3708
AdguardTeam/AdguardFilters#24339

cooking.nytimes.com#$#html.nytc---modal-window---noScroll { overflow: visible!important; }
cooking.nytimes.com#$#body.nytc---modal-window---noScroll { overflow: visible!important; }
cooking.nytimes.com##.nytc---modal-window---isShown:not(:has(.nytc---largepicturemodal---contentBody > .nytc---x---x.nytc---largepicturemodal---xBtn[role="button"]))

uBO rewrite last filter:

cooking.nytimes.com##.nytc---modal-window---isShown:if-not(.nytc---largepicturemodal---contentBody > .nytc---x---x.nytc---largepicturemodal---xBtn[role="button"])

Steps to Reproduce

1. Open website
2. block pop-up with AdGuard rewrite filter
3. button (link) login no works - no open Window login with ":x:" button.

Expected behavior:

filter works same as in AdGuard with :if-not() construction on uBO.

Actual behavior:

filter no works same as in AdGuard with :if-not() construction on uBO.

Your environment

• uBlock Origin version: uBO 1.17.4
• Browser Name and version: Firefox 64 x64
• Operating System and version: Windows 7 Pro x64

[gorhill]

I don't understand what you are reporting. Your filter matches one element on the page, the overlay box. Seems to me this is what you would want? What does "cut to much in uBO" mean?

[krystian3w]

Try block first pop-up and no block normal login pop-up.

Use this same partent html element.

First no have ❌ button, secound have.

[gorhill]

first pop-up

What first pop-up? I get a "Join NYT Cooking".

Please be detailed, clear, applied, concise and provide screenshots if needed, I just can't understand what you are reporting.

[gorhill]

Also, you did not check the box "I verified that this is not a filter issue". Why? If you want assistance with filter issues, this is not the place.

[krystian3w]

First annoye pop-up:

Secound from login link :

have ":x:"

[uBlock-user]

Are you saying that you cannot close the login popup with those filters ?

[krystian3w]

No posible hide (and close first pop-up) without analize JavaScirpt or blocking login for all users.

[krystian3w]

AdGuard have workaround with :if-not() - no use helped attrib for html emements with JavaScript :has() filter?

[gorhill]

After I click "Log in", I get no close button even without uBO, why should that be a uBO issue?

[uBlock-user]

I disabled cosmetic filtering and the X still doesn't appear on refresh, I think they removed on purpose or the website is broken.

[krystian3w]

Or Login FAKE wall.

[gorhill]

AdGuard have workaround

Why do you want a workaround when the filter you provide seems to work fine? I am at a lost to understand exactly what issue you are reporting here.

[uBlock-user]

He thinks uBO removed the X button from the login popup, which is not the case.

[krystian3w]

Nope, uBO no analize again code to remove attrib if X button exsist in hidden element.

Website use same code to show two pop-up's.