Add Chinese browser scheme to default whitelist

[cherinyy]

Prerequisites

• I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
• This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
• This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
• The issue is not present after disabling uBO in the browser.
• I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

• uBO is the only extension.
• uBO uses default lists and settings.
• using a new, unmodified browser profile.

Description

I noticed the following warning in the documentation:

Removing the predefined trusted site directives without understanding the consequences could cause your browser to malfunction.

So I found that three browsers that are common in the Chinese mainland don't exist in the list: 360 Security Browser, QQ Browser and Sogou Browser.

They are based on Chromium, but use their own scheme.

I tried to submit a PR, but the repository limits who can submit PRs.

A specific URL where the issue occurs.

https://github.com/cherinyy/uBlock/commit/4fa6b765fb3ae2176f8ab0be582de28382d346b9

Steps to Reproduce

N/A

Expected behavior

Browser Scheme in predefined trusted sites.

Actual behavior

Browser Scheme is not in the predefined trusted sites.

uBO version

1.55.0

Browser name and version

360 Security Browser 15, QQ Browser 12 and Sogou Browser 12

Operating System and version

Windows 11, version 23H2

[gorhill]

Do you see these schemes reported in the logger when filter lists update?

[cherinyy]

Is this consistent? I can't use the interceptor because the interceptor page will be redirected to the browser homepage after refreshing.

It seems that Sogou Browser is based on QQ Browser, which is no surprise since Sogou was acquired by Tencent. They use qqbrowser-scheme.

360 Security Browser uses chrome-scheme, so don't worry about it.

[gorhill]

I am wondering the context in which lists are fetched, for example in Chromium:

With Firefox:

Here is my thinking: instead to keep adding schemes which at this point appear inconsequential, maybe just stick to the ones which are consequential, i.e. the ones which are the context in which filter lists are fetched. This means the real change in the end would be to remove a bunch of schemes.

[uBlock-user]

This means the real change in the end would be to remove a bunch of schemes.

Example - wyciwyg-scheme

[cherinyy]

Okay, I think I understand.

They all show up as cjpalhdlnbpafiamejdnhcphjbkeiagm.chrome-extension-scheme (Chrome Web Store version), so that means it doesn't matter?

[gorhill]

If they use cjpalhdlnbpafiamejdnhcphjbkeiagm.chrome-extension-scheme internally then there is no need to add more schemes, chrome-extension-scheme is already trusted.

[cherinyy]

ok, thank you for your answers.

[gwarser]

Opera, Vivaldi, Edge, all use chrome-extension-scheme.

(side note - the whole toolbar with page selector does not react to mouse click and does not react to hover correctly on Opera 106.0.4998.70/uBO 1.55.0)

[uBlock-user]

Opera, Vivaldi, Edge,

Include Brave too

[u-RraaLL]

I see that the obsolete directives are now marked as my custom trusted sites. Sure, I can delete them and leaving them in won't really cause problems, but the troubleshooting info for all previous users will now contain 7 additional trusted sites. Is it not possible to actually remove them from trusted sites when updating?

[partingscientist]

I have three different installations on my machine (two developer builds, one stable build), each on a different Firefox profile. On the stable one, the directives seemed to be removed after 1.57.0. On both the developer ones, the directives stayed. I can delete them myself obviously, but did I miss a step that caused this to not work?

[gorhill]

I looked at the code and it's not saving the removals, that is the issue. Too late to fix this though because in the meantime people might have added those.