Increase the numerical limit for allowed values in set-cookie

[peace2000]

Prerequisites

• I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
• This is NOT an issue with YouTube, Facebook or Twitch.
• This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
• The issue is not present after disabling uBO in the browser.
• I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

• uBO is the only extension.
• uBO uses default lists and settings.
• using a new, unmodified browser profile.

Description

I propose increasing the numerical limit of set-cookie scriptlet.

I suggest the new limit to be 111.

Reasoning:

This page: https://launer.com/ uses values from 100 - 111 to define what cookie settings are accepted.
(It also uses value 000 to say that no cookies are accepted but that value is not reasonable for us anyway...)

A specific URL where the issue occurs.

https://launer.com/

Steps to Reproduce

1. Add launer.com##+js(set-cookie, cookie_consent, 100) or launer.com##+js(trusted-set-cookie, cookie_consent, 111)

Expected behavior

Those values would be accepted by the scriptlet.

Actual behavior

They are not accepted.

uBO version

1.54.1b8

Browser name and version

FF 120.0.1

Operating System and version

Win 10

[gwarser]

Looks like bitfield, any time more digits can be added.

[peace2000]

set-local-storage-item accepts values up to 32767 https://github.com/gorhill/uBlock/wiki/Resources-Library#set-local-storage-itemjs- ... is there a reason to keep the value as low as 15 for set-cookie?

Looks like bitfield, any time more digits can be added.

True, one way to handle this could be to allow a limitless sequence of 0 / 1 values but so far gorhill has wanted actual cases as a justification to add more values.

[gorhill]

I implemented set-cookie according to AdGuard's documentation.

Now I am facing an open ended stream of requests to constantly add to it. I think at this point this should involve AdGuard too, there might be good reasons these limits were put in place. cc @ameshkov

[peace2000]

Here is the reason :

* [Why can't I set the cookie value to a number greater than 15? AdguardTeam/Scriptlets#121](https://github.com/AdguardTeam/Scriptlets/issues/121)

it's dangerous to provide an option to set an arbitrary cookie, so we made set-cookie scriptlet similar to set-constant with possible values which where the most used in filter lists AdguardTeam/Scriptlets#79

No reason was stated why values above 15 are too arbitrary for set-cookie but not arbitrary for set-local-storage-item. The only reason for 15 seems to be cover "mostly used" values. Though that 32767 is still unclear as AG doesn't seem to use that high values in their set-local-storage-item filters... Unless I missed them. :)

[ameshkov]

@gorhill
I suggest keeping scriptlets consistent and having the allowed constants similar in all three: set-constant / set-cookie / set-local-storage-item. Linked issue in our repo: AdguardTeam/Scriptlets#388

[ryanbr]

Since its binary values, maybe just cover 3-4 digit binarys? Not ideal but an option

[ryanbr]

Another option to improve set-local/session/cookie, is for these values to be shared. Since we have a few set-cookie options, why not just cover them all.

[slavaleleka]

we have decided to increase the limit up to 32767 for AdGuard's cookie setting scriptlets

[krystian3w]

So simple set-constant sill will support small range 0-15?

[slavaleleka]

@krystian3w what are you talking about? set-constant has always supported positive decimal integer <= 32767

[gorhill]

This was fixed months ago: gorhill/uBlock@9146134