Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate icons to FontAwesome svg files (from the font file) #249

Closed
gorhill opened this issue Oct 1, 2018 · 4 comments
Closed

Migrate icons to FontAwesome svg files (from the font file) #249

gorhill opened this issue Oct 1, 2018 · 4 comments
Labels
fixed issue has been addressed

Comments

@gorhill
Copy link
Member

gorhill commented Oct 1, 2018

Latest FontAwesome version make available a package[1] where each individual icon is defined in a plain svg file. Given this I want to import only the needed svg files into a single svg defs files and use inline svg.

I started such conversion work in uMatrix (gorhill/uMatrix@c6e29be#diff-4de122c13cf2cc4e2364626b0acdb2c9).

[1] https://use.fontawesome.com/releases/v5.3.1/fontawesome-free-5.3.1-web.zip

@uBlock-user uBlock-user added the something to address something to address label Oct 3, 2018
@uBlock-user uBlock-user added TODO todo and removed something to address something to address labels Dec 10, 2018
gorhill added a commit to gorhill/uBlock that referenced this issue Dec 17, 2018
gorhill added a commit to gorhill/uBlock that referenced this issue Dec 17, 2018
- Add tooltip support (not yet complete):
  #1222
- Add a link to logger documentation:
  #2876 (comment)
- Migrate to from fontawesome font to svgs:
  uBlockOrigin/uBlock-issues#249
@gorhill gorhill reopened this Dec 18, 2018
@gorhill
Copy link
Member Author

gorhill commented Dec 19, 2018

It looks like Fontawesome 5 is no longer developed by the original author. I don't like what they have done with some of the icons. It's going to be tedious work but I will be importing/converting manually the Fontawesome 4 (original author) icons as proper svg entities through Inkscape (converting as proposed here does not work -- for example the code icon is really 1830 units wide, but that information is nowhere to be found in the svg font file + other issues).

@grenzor
Copy link

grenzor commented Dec 19, 2018

There's also a fork of Fontawesome 4.7 which continues on the original author's work at https://github.com/ForkAwesome/Fork-Awesome. Might be worth a look.

@gorhill
Copy link
Member Author

gorhill commented Dec 19, 2018

Well I had no idea, thanks for the tip.

When I dug more into Fontawesome 5 yesterday I became uneasy about using it as it seemed the original author is no longer part of the project and some changes in the icons were dubious, for example the double-angle-up and code are now bold-looking while they used to be regular in v4 (the regular versions are no longer free...)

Looking at Forkawesome, I will still have to import manually, the svgs files in the repo still have the issues I am fixing with Fontawesome 4.7. For example, this icon is not centered in its viewbox, and this causes issues: can't transform cleanly, and width is not representative of the width of the icon.

@uBlock-user
Copy link
Contributor

The fonts used in the latest dev build are thicker and bigger, is that because of the new dev ?

gorhill added a commit to gorhill/uMatrix that referenced this issue Dec 26, 2018
Found out Fonteawesome 5 is a different project than
former Fontawesome (of which 4.7 is latest).

See uBlockOrigin/uBlock-issues#249 (comment)
gorhill added a commit to gorhill/uBlock that referenced this issue Dec 6, 2020
@gorhill gorhill closed this as completed Dec 6, 2020
@uBlock-user uBlock-user added fixed issue has been addressed and removed TODO todo labels Dec 6, 2020
Noxgrim pushed a commit to Noxgrim/uMatrix that referenced this issue Dec 29, 2021
Found out Fonteawesome 5 is a different project than
former Fontawesome (of which 4.7 is latest).

See uBlockOrigin/uBlock-issues#249 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants