-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Restore from file..." may not work in Firefox for Android #2378
Comments
Restoring freezes the UI for me. I can scroll, but no buttons work. I can open tab list and it then unfreezes. The dialog does not appear. It seems, screen is dimmed, like with dialog, but no actual dialog appear. Firefox bug? |
@gwarser Why is this "closed as completed"? (rather than "not planned") |
Because I cannot reproduce anymore on Firefox mobile. Can be related to file access permissions or this https://bugzilla.mozilla.org/show_bug.cgi?id=1797558 |
If I try restoring from Firefox home page, by launching uBO settings from add-on manager, then after applying the backup, Firefox will close the only tab leaving the browser with graphical glitch - uBO interface painted over "nothing". Just create new tab from menu and all will work fine. If I try restoring by first opening any page (like |
That seems consistent with my experience with the issue. I'll try restoring the backup from somewhere other than the homepage |
I tested, but the same behavior happens, regardless of homepage or site. The UI hangs, and there's no confirmation pop-up (usually) |
It seems that there is a bug in Firefox for Android that causes Window.confirm() and window.alert() to fail to execute after selecting a file, since the error message by window.alert() when selecting the wrong file also does not seem to execute. |
I have been experiencing this bug sometimes occasionally in the past. When trying to restore a backup file, after selecting the backup file in file manager, no popup was appearing and nothing was happening, other time there was some lag/freeze, but finally again - still nothing was happening. But it was not a big problem for me, because then usually after 2nd or 3rd try, the popup was finally appearing and the backup file was imported properly. But now, it has become a serious problem for me, because importing backup file doesn't work permanently, no matter how many times I try, even resetting uBO to default or reinstalling uBlock doesn't help to fix it. I am currently on Firefox 130 Mobile and have experienced it today, permanently unable to import the backup file - no popup appears. Importing the same backup file on Kiwi, on the same phone, works fine.
There is another one, but it's stale/idle since a year:
UPDATED: Finally it has imported the backup file after X tries of reinstalling the extension, but it's not easy to make it work, and most likely it will break again soon. |
For me, this problem appears because before I disabled default file manager in Android. |
Prerequisites
I tried to reproduce the issue when...
Description
A bug exists on Firefox for Android that may prevent restoration from a file.
This bug does not always occur and sometimes it works fine after multiple attempts.
On some devices, the restoration operation can be performed normally without the bug.
https://user-images.githubusercontent.com/111569199/203508375-5187622a-8b36-49ef-a3e8-c0cc629fc28f.mp4
A specific URL where the issue occurs.
moz-extension://[different add-on ID per device]/dashboard.html#settings.html
Steps to Reproduce
1.Open Settings.
2.Press "Restore from file..." button.
3.Select backup of ublock settings.
Expected behavior
A pop-up dialog will appear asking if you want to restore the settings.
Actual behavior
No pop-up dialog appears and settings are not restored.
However, if you then select "Reset to default settings..." afterwards, it will behave as if the dialog has already appeared multiple times (check box to prevent the dialog from appearing again).
uBO version
uBlock Origin 1.45.2
Browser name and version
Firefox Beta for Testers 108.0b3
Operating System and version
OPPO A5 2020 (Android 10)
The text was updated successfully, but these errors were encountered: