Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud storage banner in settings appears almost completely white #1389

Closed
3 tasks
polygonnedpotato opened this issue Dec 7, 2020 · 1 comment
Closed
3 tasks
Labels
invalid not a uBlock issue

Comments

@polygonnedpotato
Copy link

polygonnedpotato commented Dec 7, 2020

Prerequisites

  • [x ] I verified that this is not a filter issue
  • [x ] This is not a support issue or a question
  • [x ] I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • [x ] I am running the latest version of uBlock Origin
  • [x ] I checked the documentation to understand that the issue I report is not a normal behaviour

Description

[Description of the bug or feature]
The cloud storage bannershows up with white fonts in dark mode

image

A specific URL where the issue occurs

[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]

Steps to Reproduce

  1. [First Step]
    open settings
  2. [Second Step]
    Check "I am an advanced user" and set "uitheme" to "dark" and hit apply changes
  3. [and so on...]
    open "Filter lists", "My filters", "My rules", or "Trusted sites".

Expected behaviour:

the banner should show up with a dark background
[What you expected to happen]

Actual behaviour:

the banner shows up with white font and background
[What actually happened]

Your environment

  • uBlock Origin version: 1.31.2
  • Browser Name and version: Chrome 86.0.4240.199
  • Operating System and version: Chrome OS (64-bit) 86.0.4240.199
@gorhill
Copy link
Member

gorhill commented Dec 7, 2020

https://github.com/gorhill/uBlock/wiki/Advanced-settings#uitheme:

For development purposes only! DO NOT create issues about this feature!

Since asking people to not file issue does not work, I will disable the setting to prevent such invalid issue.

@gorhill gorhill closed this as completed Dec 7, 2020
@gorhill gorhill added the invalid not a uBlock issue label Dec 7, 2020
gorhill added a commit to gorhill/uBlock that referenced this issue Dec 8, 2020
Related issue:
- uBlockOrigin/uBlock-issues#1389

Asking people to respect the warning in the documentation
does not work, consequently the setting will be now disabled
for stable releases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid not a uBlock issue
Projects
None yet
Development

No branches or pull requests

2 participants