Some RegExp filters are not parsed properly

[jspenguin2017]

Prerequisites

• I verified that this is not a filter issue
  • Filter issues MUST be reported at filter issue tracker
• This is not a support issue or a question
  • Support issues and questions are handled at /r/uBlockOrigin
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • Your issue may already be reported.
• I tried to reproduce the issue when...
  • uBlock Origin is the only extension
  • uBlock Origin with default lists/settings
  • using a new, unmodified browser profile
• I am running the latest version of uBlock Origin
• I checked the documentation to understand that the issue I report is not a normal behavior

Description

This EasyList filter is not parsed properly. An error is logged to the background console instead:

/^https:\/\/([a-z]+\.)?sythe\.org\/\[=%#@$&!^].*[\w\W]{20,}/$image

The RegExp is kind of weird, but nevertheless is a valid RegExp.

A specific URL where the issue occurs

chrome://extensions/

Steps to Reproduce

1. Update EasyList or add the filter above to my filters

Expected behavior:

Filter parsed correctly.

Actual behavior:

Error logged to the background console.

Your environment

• uBlock Origin version: 1.27.2
• Browser Name and version: Chrome 84.0.4143.7
• Operating System and version: Windows 10.0.18363.778

[kulfoon]

jspenguin2017 : The RegExp is kind of weird, but nevertheless is a valid RegExp.
image

Yes, while it's still a technically valid regex it seems that what you're calling "weird" is a bug (a typo) - an unwanted excape char \ in the middle - should be /[ and not /\[, coz I don't think that the author or anybody else wanted to escape [ in that place, he simply wanted to pick any character between [] square brackets, which (the square brackets) should not be escaped in this case, so the intended regex would be: /^https:\/\/([a-z]+\.)?sythe\.org\/[=%#@$&!^].*[\w\W]{20,}/$image

Seems lika a bug in uBO, because the fixed version of the regex not working in uBO as well:
/^https:\/\/([a-z]+\.)?sythe\.org\/[=%#@$&!^].*[\w\W]{20,}/$image
it should match and block this example request:
https://xxx.sythe.org/&xderf45tghyt56yhjuikjuytrf.jpg (LINK TO TEST)
but the logger shows it's not blocked.

The bug in uBO is about distinguishing between cosmetic filters - which contain ## or #@ and regex filters which might occasionally contain the same.

[gwarser]

It's just parser error. Swap #@ in place and it will work. Simple example [of filter which does not work]:

/#@/

[gorhill]

I fixed it yesterday locally, but for the next dev cycle I had planned to rewrite and separate FilterParser from static network filtering engine (so that it can be loaded separately in auxiliary pages for example), so it's probably going to be fixed as part of the rewrite.

[kulfoon]

gwarser : Simple example : /#@/

This won't work either, you have a typo in the example, you actually didn't swap it, you meant: /@#/

We got 3 bugs/typos already: Typo in the regex, a bug in uBO parser, and a typo in the comment, but hey - no offence, Human beings make mistakes.

[gwarser]

This is simplest example of filter which does not work.

[uBlock-user]

We got 3 bugs/typos already: Typo in the regex, a bug in uBO parser, and a typo in the comment

Because of lack of installation of dev-builds to catch these bugs. Had more people installed devbuilds, this would have been caught before the stable release occurred.

[kulfoon]

gwarser : This is simplest example of filter which does not work.

Ok then, good to know, coz your previous comment looks confusing, it looks more like you wanted to provide the simplest example of filter which does work, especially after placing the example after previously suggesting swapping and providing an identical example, why duplicating the example then.