Source code viewer's output is difficult to read in 1.47.5b7-b8 on dark theme

[u-RraaLL]

Moving discussion outside commit comments per suggestion.

The new colors on Dark Mode now make code difficult to read.

You are talking about the code viewer only?

Yes.

I used an official CodeMirror theme as I do not want to go through all the coloring stuff again. You can suggest one from there: https://codemirror.net/5/demo/theme.html.

I went though the themes, they're all readable. They're not what I see in b7 (and now b8).

This is what I see in b7-8:

This is what I see in b6:

Though, since you're asking, my personal favorite would be seti.

I'm going to look into this. We should move to a discussion though, here is not ideal.

[gorhill]

Should be fixed in 1.47.5b9

[Yuki2718]

Also highlights in asset-viewer is difficult to read:

Screenshot

[Yuki2718]

Yup, looks nice!

[gorhill]

CodeMirror uses a color with an alpha value, I discarded this alpha value when I worked on theme stuff. I just need to bring it back. The blue color could be mistaken as a selection, I find it confusing.

I just needed to ensure the --cm-searching-ink value used for text color of search matches was not being overridden.

[peace2000]

If blue isn't good, how about making the yellow color more fade?

Screenshot

#fee3003d

This option might not be so beautiful but I think that it's important to be able easily discern the highlighted text.

[gorhill]

There was already a color set for the text of search matches, it was being overridden while the original intention was to not have it overridden -- this is fixed in latest dev build.

[peace2000]

This looks a lot better!:

Latest dev:

Screenshot

Latest stable:

Screenshot

[u-RraaLL]

@gorhill there seems to be some glitch in code viewer's searchbar. The match count doesn't show up for me if I don't open dev tools (I used inspect element to see if the counter was missing in the tool).

If I refresh with dev tools open and try a new search, the counter will show up quickly,. If I close dev tools and repeat, the counter doesn't appear. Even if I use the arrows to switch between matches.

Didn't seem big enough to make a new issue, so reporting here instead.

[peace2000]

I currently have been able now to reproduce apparently reliably (in Firefox):

* Force a reload of the code viewer tab (assuming you have opened to view some source)

* Search for a term which does not exist (I use `toto`)

* Remove the failed search term and search for something which exist: the count does not show up

This way I can repro also. Though I don't need to force reload the tab.

[gorhill]

The match count doesn't show up for me if I don't open dev tools

Hmm you are right, when I have the issue, opening the dev tools makes it go away immediately. I am starting to wonder if this is a Firefox issue with CSS :empty, which is used to either hide or show the search count.

[gorhill]

So far appear to have fixed it on my side: gorhill/uBlock@b6a5424.

[u-RraaLL]

Tested on Linux and Windows. It's fixed for me too.

[peace2000]

I confirm uBO 1.48.9b2 fixed this issue for me as well.