Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google.com to anti click trackers list #19365

Closed
wants to merge 2 commits into from
Closed

Add google.com to anti click trackers list #19365

wants to merge 2 commits into from

Conversation

Nomes77
Copy link
Contributor

@Nomes77 Nomes77 commented Aug 16, 2023

URL(s) where the issue occurs

https://www.google.com

Describe the issue

When clicking on search results, google.com redirects it via their own server. Try https://www.google.com/search?q=example.com%252Ftest%253Fq%253Dtest as a test

Screenshot(s)

[Screenshot(s) for difficult to describe visual issues are mandatory]

Versions

  • Browser/version: 116.0.2
  • uBlock Origin version: 1.51.0

Settings

None of them affects this problem.

Notes

Maybe, the rule should be narrowed down to only https://www.google.com/search? since their are more outgoing links and we don't want to break other links of google

@stephenhawk8054
Copy link
Member

There's www.google.*##+js(set, rwt, noopFunc) in annoyance list.

Does it work for you?

@Nomes77
Copy link
Contributor Author

Nomes77 commented Aug 16, 2023

Yes, it works.
So there is no need to merge this PR.

@Nomes77 Nomes77 closed this Aug 16, 2023
@Nomes77 Nomes77 deleted the master-1 branch August 16, 2023 13:18
@MasterKia
Copy link
Member

@stephenhawk8054 I think that rule should be moved to privacy.

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Aug 16, 2023

If I'm not mistaken, that one was put in annoyance list due to not sure if it causes breakages somewhere.

@Yuki2718 @uBlock-user @okiehsch Do you remember if that filter had any drawbacks?

@Yuki2718
Copy link
Contributor

I don't.

@MasterKia
Copy link
Member

One potential breakage could be that the visited links might not appear in the "History" section.

Someone with a Google account could test that.

@stephenhawk8054
Copy link
Member

Hmmm... I checked google activity settings and it just shows search history (aka search terms used), but not links clicked.

@MasterKia
Copy link
Member

And without that filter, it shows the clicked links?

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Aug 16, 2023

I mean without that filter. I don't see any sections in google settings that shows the clicked ones (or I haven't found it yet).

@uBlock-user
Copy link
Contributor

uBlock-user commented Aug 16, 2023

No, no breakages from this one. The one I suggested to previous OP had some breakages come out later on, so replaced with this one.

History - #7960

@stephenhawk8054
Copy link
Member

Ok, I'll move it to privacy list. Due to the update gap of both lists, we can keep in both until next week.

stephenhawk8054 added a commit that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants