Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

market-delivery.yandex.ru: breakage #18853

Closed
8 of 9 tasks
yabl04 opened this issue Jul 6, 2023 · 7 comments
Closed
8 of 9 tasks

market-delivery.yandex.ru: breakage #18853

yabl04 opened this issue Jul 6, 2023 · 7 comments

Comments

@yabl04
Copy link

yabl04 commented Jul 6, 2023

Prerequisites

  • I read and understand the policy about what is a valid filter issue.
  • I verified that this issue is not a duplicate. (Use this button to find out.)
  • I forced an update of my filter lists. (Click the "Purge all caches" button while holding the 'Shift' key, then click the "Update now" button.)
  • I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
  • I did not enable external filter lists, or I have verified that the issue still occurs without enabling external filter lists.
  • I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
  • I am not using uBlock Origin (uBO) along with other content blocker extensions.
  • I have verified that the web browser's built-in blocker or DNS blocking (standalone or through a VPN) is not causing the issue.
  • I did not answer truthfully to ALL the above checkpoints.

URL address of the web page

https://market-delivery.yandex.ru/

Category

breakage

Description

Не загружает сайт
image

Other extensions used

Screenshot(s)

Screenshot(s)

Configuration

uBlock Origin 1.50.0:
 since: 24d.13h.22m
Chromium: 114
filterset (summary):
 network: 181191
 cosmetic: 180783
 scriptlet: 37158
 html: 0
listset (total-discarded, last-updated):
 added:
  adguard-cookies: 26204-41, 2h.43m
  adguard-generic: 72258-622, 2h.43m
  adguard-mobile: 8367-65, 2h.43m
  adguard-mobile-app-banners: 4399-9, 2h.43m
  adguard-other-annoyances: 13037-43, 2h.43m
  adguard-popup-overlays: 22890-411, 2h.43m
  adguard-social: 20831-887, 2h.42m
  adguard-spyware: 60326-1298, 2h.42m
  adguard-spyware-url: 1114-3, 2h.42m
  adguard-widgets: 2195-18, 2h.42m
 default:
  user-filters: 9-0, never
  RUS-0: 39456-9, 2h.43m
  easylist: 67885-1013, 2h.42m
  easyprivacy: 33403-16679, 2h.42m
  plowe-0: 3740-1241, now
  ublock-badware: 7488-365, 2h.42m
  ublock-filters: 33823-4167, 2h.42m
  ublock-privacy: 425-65, 2h.42m
  ublock-quick-fixes: 280-15, 3h.12m
  ublock-unbreak: 2064-134, 2h.42m
  urlhaus-1: 6356-2, 2h.42m
filterset (user): [array of 9 redacted]
userSettings:
 advancedUserEnabled: true
 showIconBadge: false
hiddenSettings: [none]
supportStats:
 allReadyAfter: 19643 ms (selfie)
 maxAssetCacheWait: 1013 ms
popupPanel:
 blocked: 3
 network:
  yandex.ru: 3
 extended:
  ##+js(cookie-remover, /^bltsr$|^JPIqApiY$|^specific$|^substantia…
  ##+js(json-prune, seatbid rtb direct):matches-path(/images)
  ##+js(noeval-if, Id":"R-I):matches-path(/\/(?:weather\/|pogoda\/…
  ##+js(abort-on-property-read, Object.prototype.renderDirect):mat…
  ##+js(json-prune, rtb):matches-path(/\/(?:weather\/|pogoda\/|hav…
  ##+js(json-prune, seatbid):matches-path(/video)
  ##+js(json-prune, direct rtb):matches-path(/games)
  ##+js(json-prune, rtb seatbid):matches-path(/sport)
  ##+js(json-prune, direct rtb):matches-path(/q)
  ##+js(remove-attr, data-counter, .serp-list a[href]):matches-pat…
@stephenhawk8054
Copy link
Member

It's caused by the filter

yandex.*##+js(aopr, Object.prototype.renderDirect):matches-path(/\/(?:weather\/|pogoda\/|hava\/)/)

in AdGuard – Popup Overlays list.

@gorhill At first, I thought matches-path filters with scriptlets will automatically be discarded, but looks like they're not?

@gorhill
Copy link
Member

gorhill commented Jul 7, 2023

The scriptlet injection syntax parser doesn't know about cosmetic procedural operators syntax, so from the point of view scriptlet injection syntax parser, what follows aopr is just a (weird-looking) argument.

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Jul 7, 2023

Ah ok I understand now, it sees Object.prototype.renderDirect):matches-path(/\/(?:weather\/|pogoda\/|hava\/)/ as a whole object.

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Jul 7, 2023

Hmmm... so how should we resolve issues with matches-path like this? I think we can add

yandex.*#@#+js(aopr, Object.prototype.renderDirect):matches-path(/\/(?:weather\/|pogoda\/|hava\/)/)

but I'm not sure which list should handle these issues.

@gorhill
Copy link
Member

gorhill commented Jul 7, 2023

@gorhill
Copy link
Member

gorhill commented Jul 7, 2023

It has to be handled by us until the conversion code in AdGuard is fixed.

@stephenhawk8054
Copy link
Member

Ok, I think we can put it to unbreak.

stephenhawk8054 added a commit that referenced this issue Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants