Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidal.com: breakage #17495

Closed
6 tasks done
TommyDeCortez opened this issue Apr 8, 2023 · 19 comments
Closed
6 tasks done

tidal.com: breakage #17495

TommyDeCortez opened this issue Apr 8, 2023 · 19 comments

Comments

@TommyDeCortez
Copy link

TommyDeCortez commented Apr 8, 2023

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

When I create new playlist on Tidal web player then I can not add new song. When I shutdown uBlock origin I can add new song to the playlist.

URL(s) where the issue occurs.

www.tidal.com

Screenshot(s)

No response

uBO version

Latest

Browser name and version

MS Edge - latest, Brave browser - latest

Settings

Shut off uBlock filters - then playlist is O.K.

Notes

When I create new playlist on Tidal web player then I can not add new song. When I shutdown uBlock origin I can add new song to the playlist. When is uBlock on i gave message: "This playlist has been modified elsewhere"
This cause uBlock filters, when is shut down I have no problem with playlist but I have audio advetisement.

@mapx-
Copy link
Contributor

mapx- commented Apr 8, 2023

A subscription is required.

First of all, follow the all the indications bellow. If you still experience issues, we'll ask you if you are willing to send (privately) your account credentials in order to be able to further investigate your issue.

  • clear cookies / localStorage/ cache for the tested page
  • reset uBO, don't modify any uBO setting, update all the filter lists, don't add any other list (other than your regional list)
  • disable any custom filter for that site
  • disable any other extension / addon in your browser, disable builtin blockers /shields/ tracking protection in brave/ opera/ vivaldi/ edge/ firefox etc
  • if Opera browser: open opera://extensions/ and check the "allow access to search page results" option
  • disable (if any) the web shields in your antivirus / antimalware software / other blocking software
  • are you using a DNS which features adblocking (like AdGuard DNS)?=> test using another DNS (google for example => IP addresses 8.8.8.8 & 8.8.4.4)
  • restart the system, reopen the browser, test again.

@TommyDeCortez
Copy link
Author

TommyDeCortez commented Apr 8, 2023

I tried everything but with no result. This cause problem:
listen.tidal.com##+js(no-fetch-if, /\d\?country/)
but when is shut off i have audio advertisement.

@MasterKia MasterKia changed the title Tidal - playlist tidal.com: breakage Apr 8, 2023
@stephenhawk8054
Copy link
Member

Test account here (with US IP): https://github.com/uBlockOrigin/uBlock-discussions/discussions/465

The regex needs to be changed I think, but other regexes did not work last time I checked. I still don't know why.

@mapx-
Copy link
Contributor

mapx- commented Apr 8, 2023

@TommyDeCortez

could you test

listen.tidal.com#@#+js(no-fetch-if, /\d\?country/)
listen.tidal.com##+js(no-fetch-if, /\/tracks\/.*\d\?country/)

@TommyDeCortez
Copy link
Author

@TommyDeCortez

could you test

listen.tidal.com#@#+js(no-fetch-if, /\d\?country/)
listen.tidal.com##+js(no-fetch-if, /\/tracks\/.*\d\?country/)

Add new song to the playlist work but I have audio advertisement.

@stephenhawk8054
Copy link
Member

I think it might relate to service workers: unregister the workers at chrome://serviceworker-internals/ and about:serviceworkers

||tidal.com^$csp=worker-src 'none'

?

@stephenhawk8054
Copy link
Member

@TommyDeCortez Do these work for you?

listen.tidal.com#@#+js(no-fetch-if, /\d\?country/)
listen.tidal.com##+js(no-fetch-if, /\/users\/.*\d\?country/)

@TommyDeCortez
Copy link
Author

@TommyDeCortez Do these work for you?

listen.tidal.com#@#+js(no-fetch-if, /\d\?country/)
listen.tidal.com##+js(no-fetch-if, /\/users\/.*\d\?country/)

It does not work. Add to playlist works. The audio ad remains but the player disappears when it plays.

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Apr 9, 2023

Well, last effort, can you do these steps?

  1. Go to chrome://serviceworker-internals/ for Chromium browsers (or about:serviceworkers for Firefox) and find TIDAL service worker -> Unregister it.
  2. Add these filters:
listen.tidal.com#@#+js(no-fetch-if, /\d\?country/)
listen.tidal.com##+js(no-fetch-if, /\/tracks\/.*\d\?country/)
listen.tidal.com##+js(no-fetch-if, /\/users\/.*\d\?country/)
||pushkin-v2.tidal.com/public/token/*/ws$websocket,1p
||listen.tidal.com/*/rt/connect$xhr,1p
||tidal.com^$csp=worker-src 'none'
  1. Clear cookies and cache of TIDAL, log in and test again.

If it doesn't work, we can only remove the filter to prevent breakage, as I cannot reproduce the ads anymore.

@TommyDeCortez
Copy link
Author

listen.tidal.com#@#+js(no-fetch-if, /\d\?country/)
listen.tidal.com##+js(no-fetch-if, /\/tracks\/.*\d\?country/)
listen.tidal.com##+js(no-fetch-if, /\/users\/.*\d\?country/)
||pushkin-v2.tidal.com/public/token/*/ws$websocket,1p
||listen.tidal.com/*/rt/connect$xhr,1p
||tidal.com^$csp=worker-src 'none'

Looks like it's working.
Thank you very much

@stephenhawk8054
Copy link
Member

Can you test without the last filter (the worker-src one)

@stephenhawk8054
Copy link
Member

For me it works without the $csp filter. However the main thing is it still comes with a breakage:

image

The profile section at the top left cannot show and I cannot click on it due to listen.tidal.com##+js(no-fetch-if, /\/users\/.*\d\?country/) (this filter makes Tidal's server not being able to recognize user's ID to deliver the ads I think), and I'm not sure if there would be other breakages or not. At least it's a bit better than the current situation.

@mapx- I'm not sure if we should add the filters or not regarding this breakage. I think it would be more suitable for an Experimental/Extra list than main list.

@mapx-
Copy link
Contributor

mapx- commented Apr 10, 2023

We should remove that breaking filter and if the other filters cause other breakages, well, for now nothing to do

thanasistrisp added a commit to thanasistrisp/tidal-hifi that referenced this issue Apr 20, 2023
Mastermindzh pushed a commit to thanasistrisp/tidal-hifi that referenced this issue Apr 22, 2023
@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Jun 10, 2023

Hmmm... Looks like this filter works for me without any breakages:

listen.tidal.com##+js(json-prune, countryCode)

Can anyone else test it?


Feedbacks:

https://www.reddit.com/r/uBlockOrigin/comments/144ukk9/is_there_any_new_filters_for_tidal/jnhpg3a/

stephenhawk8054 added a commit that referenced this issue Jun 11, 2023
@TommyDeCortez
Copy link
Author

Hmmm... Looks like this filter works for me without any breakages:

listen.tidal.com##+js(json-prune, countryCode)

Can anyone else test it?

Feedbacks:

https://www.reddit.com/r/uBlockOrigin/comments/144ukk9/is_there_any_new_filters_for_tidal/jnhpg3a/

When I use this filter, the Tidal page doesn't load at all

@stephenhawk8054
Copy link
Member

@TommyDeCortez Try this

listen.tidal.com##+js(json-prune, countryCode, tidalId)

@TommyDeCortez
Copy link
Author

@TommyDeCortez Try this

listen.tidal.com##+js(json-prune, countryCode, tidalId)

The page will load with this filter. But I have audio ads.

@stephenhawk8054
Copy link
Member

Hmmm... I got no ads with that filter. Did you open in new tab and test again?

@TommyDeCortez
Copy link
Author

Hmmm... I got no ads with that filter. Did you open in new tab and test again?

I try another VPN server and now it seems that it working.

topsuperdev added a commit to topsuperdev/hifi_tidal that referenced this issue Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants