this fixes #708

uBlock-LLC · Feb 6, 2015 · a24d22c · a24d22c
1 parent 863aaa5
commit a24d22c
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/js/assets.js b/src/js/assets.js
@@ -820,6 +820,13 @@ var readExternalAsset = function(path, callback) {
 
     var onExternalFileLoaded = function() {
         this.onload = this.onerror = null;
+        // https://github.com/gorhill/uBlock/issues/708
+        // A successful download should never return an empty file: turn this
+        // into an error condition.
+        if ( stringIsNotEmpty(this.responseText) === false ) {
+            onExternalFileError();
+            return;
+        }
         //console.log('µBlock> readExternalAsset("%s") / onExternalFileLoaded1()', path);
         cachedAssetsManager.save(path, this.responseText);
         reportBack(this.responseText);