Handle case of RRULE:COUNT=1 #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outlook, as reported in u01jmg3#293, may in some cases reduce `COUNT` to `1`. Whilst not disallowed in the RFC5545 spec (or any of its errata to date), having a `COUNT` of `1` has no practical purpose that I can see. We currently only check we've reached the count-limit *after* we've generated the first few recurrences of an event and - more pressingly - *after* we've appended the first candidate to the array of generated recurrences. In this case `PHP_MAX_INT` could be replaced with some suitable default number, akin to the current `defaultSpan` property used to put a limit on UNTIL. But that's something for another PR.
u01jmg3
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MS Outlook, as reported in #293, may in some cases reduce the
COUNTstanza of anRRULEto1.(Whilst not disallowed in the RFC5545 spec (or any of its errata to date), having a
COUNTof1has no practical purpose that I can see.)We currently only check we've reached the count-limit after we've generated the first few recurrences of an event and - more pressingly - after we've appended the first candidate to the array of generated recurrences.
In the solution presented in this PR,
PHP_MAX_INTcould be replaced with some suitable user-settable default number, akin to the currentdefaultSpanproperty used to put an upper limit onUNTIL. But that's perhaps something for another PR.