BYMONTHDAY Support #272
Merged
BYMONTHDAY Support #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Not to be confused with `getDaysOfMonthMatchingByDayRRule()`) Does what it says on the tin. For now, used only with the MONTHLY frequency but should be usable with DAILY as well.
The return value only differs from a previous call when the month changes, so instead of running the method every iteration of a DAILY cycle, we recreate the variable only after a month change.
u01jmg3
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
BYMONTHDAYrrule stanza under theDAILY,MONTHLYandYEARLYfrequencies; and it should function in combination with other implemented compatibleBY*stanzas (e.g.BYDAY).This PR does not add support for it under
WEEKLY, as the rfc5545 specification states:Relevant tests are included.
Refs. #11