Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter days before and after issue #217

Merged
merged 1 commit into from
May 12, 2019

Conversation

roelVerdonschot
Copy link
Contributor

@roelVerdonschot roelVerdonschot commented Apr 28, 2019

#216

When using the before and after filter events inside the range were removed, I had to update 1 line and add an extra check (parentheses) to make it work.

I changed this line in removeLastEventIfOutsideWindowAndNonRecurring()

  • if (!isset($lastEvent['RRULE']) || $lastEvent['RRULE'] === '' && $this->doesEventStartOutsideWindow($lastEvent)) {

to

  • if ((!isset($lastEvent['RRULE']) || $lastEvent['RRULE'] === '') && $this->doesEventStartOutsideWindow($lastEvent)) {

and had to add this if to the $events foreach in reduceEventsToMinMaxRange()

if ($anEvent === null) {
    unset($events[$key]);
    continue;
}

I'm using v2.1.11

@u01jmg3 u01jmg3 added this to the v2.x.x milestone May 12, 2019
@u01jmg3 u01jmg3 changed the title #216 - Possible filter days before and after bug? Fix filter days before and after issue May 12, 2019
@u01jmg3 u01jmg3 merged commit 56efee7 into u01jmg3:master May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants