Make cpud build on Darwin #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the convenience of continuous builders, make cpud build (but not work correctly) on Darwin
rminnich
approved these changes
Sep 25, 2024
|
ah you need a signed-off-by |
rminnich
reviewed
Sep 30, 2024
| @@ -14,6 +14,11 @@ import ( | |||
| "os/exec" | |||
| ) | |||
|
|
|||
| type Session struct { | |||
| binds string | |||
There was a problem hiding this comment.
remove binds, we can't do that on Darwin IIUC?
|
I think this is now obsolete? If not, please bring it back, but fix conflicts. Use the freebsd port as a model. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the convenience of continuous builders, make cpud build (but
not work correctly) on Darwin
Note that this doesn't make cpud work on Darwin -- just compile
successfully.