Skip to content

Commit

Permalink
io: change readX_relaxed() to remove barriers
Browse files Browse the repository at this point in the history
Now that we hardened readX() API in asm-generic version, readX_relaxed()
API is violating the rules when readX_relaxed() == readX() in the default
implementation.

The relaxed API shouldn't have any barriers in it and it doesn't provide
any ordering with respect to the memory transactions. The only requirement
is for reads to be ordered with respect to each other. This is achieved
by the volatile in the __raw_readX() API.

Open code the relaxed API and remove any barriers in it.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
  • Loading branch information
Sinan Kaya authored and arndb committed Apr 10, 2018
1 parent 8d14f31 commit 8875c55
Showing 1 changed file with 20 additions and 4 deletions.
24 changes: 20 additions & 4 deletions include/asm-generic/io.h
Original file line number Diff line number Diff line change
Expand Up @@ -252,19 +252,35 @@ static inline void writeq(u64 value, volatile void __iomem *addr)
* accesses.
*/
#ifndef readb_relaxed
#define readb_relaxed readb
#define readb_relaxed readb_relaxed
static inline u8 readb_relaxed(const volatile void __iomem *addr)
{
return __raw_readb(addr);
}
#endif

#ifndef readw_relaxed
#define readw_relaxed readw
#define readw_relaxed readw_relaxed
static inline u16 readw_relaxed(const volatile void __iomem *addr)
{
return __le16_to_cpu(__raw_readw(addr));
}
#endif

#ifndef readl_relaxed
#define readl_relaxed readl
#define readl_relaxed readl_relaxed
static inline u32 readl_relaxed(const volatile void __iomem *addr)
{
return __le32_to_cpu(__raw_readl(addr));
}
#endif

#if defined(readq) && !defined(readq_relaxed)
#define readq_relaxed readq
#define readq_relaxed readq_relaxed
static inline u64 readq_relaxed(const volatile void __iomem *addr)
{
return __le64_to_cpu(__raw_readq(addr));
}
#endif

#ifndef writeb_relaxed
Expand Down

0 comments on commit 8875c55

Please sign in to comment.