Skip to content

Commit

Permalink
[PATCH] quota: make useless quota error message informative
Browse files Browse the repository at this point in the history
fs/quota_v2.c can, under some conditions, issue a kernel message that says,
in totality, 'failed read'.  This patch does the following:

1) Gives a hint who issued the error message, so people reading the logs
   don't have to go grepping the entire kernel tree (with 11 false
   positives).

2) Say what amount of data we expected, and actually got.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Cc: Jan Kara <jack@ucw.cz>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
valdisk authored and Linus Torvalds committed Jan 15, 2006
1 parent d9975d6 commit 3135806
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion fs/quota_v2.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ static int v2_check_quota_file(struct super_block *sb, int type)

size = sb->s_op->quota_read(sb, type, (char *)&dqhead, sizeof(struct v2_disk_dqheader), 0);
if (size != sizeof(struct v2_disk_dqheader)) {
printk("failed read\n");
printk("quota_v2: failed read expected=%d got=%d\n",
sizeof(struct v2_disk_dqheader), size);
return 0;
}
if (le32_to_cpu(dqhead.dqh_magic) != quota_magics[type] ||
Expand Down

0 comments on commit 3135806

Please sign in to comment.