wifimanager.cpp / wifimanager.h #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added define that checks on esp32 or esp8266. If another hardware is selectec, then do not try to compile this code.
|
Do you thing we should include a #warning also just so it doesnt compile blind, I mean it is an esp exclusive library |
|
Yea, it's an ESP lib, but my compiler isn't aware of what is an ESP lib, it will try to compile .h and .cpp files which are available. The reason is, i use project specific libs and not global arduino libs. The warning may be an option, but users must enable verbose mode to see those warnings, so this will most people not help. I think the travis check isn't caused by me. |
|
What can i do to get this integrated? |
|
I will do it later |
|
Ugh Ill merge tomorrow, it wont let me since travis is failing atm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured out, that there is no check on the hardware plattform, which is currently selected.
There are serval plattforms, which does not compile, i suggest adding a if defined check to the preprocessor.
Why is this useful?
I've a multi plattform Project. I used two seprerate source code projects in the past, but now i want to merge them. When i try to compile my project with an AVR Board, it fails, because it trys to compile the wifi lib but doesn't find serval used libs.
-added define that checks on esp32 or esp8266. If another hardware is selectec, then do not try to compile this code.